Code Review Request: 7044870: TEST_BUG: java/nio/channels/DatagramChannel/SelectWhenRefused.java failed on SUSE Linux 10 (original) (raw)
Chris Hegarty chris.hegarty at oracle.com
Thu Aug 25 08:16:17 PDT 2011
- Previous message: Code Review Request: 7044870: TEST_BUG: java/nio/channels/DatagramChannel/SelectWhenRefused.java failed on SUSE Linux 10
- Next message: Code Review Request: 7060243: (dc) Multicasting tests fail on Windows XP if IPv6 is enabled
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
To close the loop on this one.
I took Kurchi's patch, incorporated Alan's comments, and pushed it.
JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9e78769c0da
-Chris.
On 25/08/2011 15:33, Alan Bateman wrote:
Kurchi Hazra wrote:
Hi,
The update code with some more styling/comment changes: The patch looks okay to me. Minor nit is that the comments should keep the existing style. Also these tests rarely use DatagramSocket and where they do then they use "ds" rather than "sock". Otherwise thanks for taking this one. -Alan.
- Previous message: Code Review Request: 7044870: TEST_BUG: java/nio/channels/DatagramChannel/SelectWhenRefused.java failed on SUSE Linux 10
- Next message: Code Review Request: 7060243: (dc) Multicasting tests fail on Windows XP if IPv6 is enabled
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]