Review Request (XS) 8006546: JSR 292: typos in the ConstantPool::copy_cp_impl() (original) (raw)
serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Mon Jan 28 14:33:43 PST 2013
- Previous message: Review Request (S) 8006542: JSR 292: the VM_RedefineClasses::append_entry() must support invokedynamic entry kinds
- Next message: Review Request (XS) 8006546: JSR 292: typos in the ConstantPool::copy_cp_impl()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Please, review the fix for (it was already reviewed by Christian): https://jbs.oracle.com/bugs/browse/JDK-8006546
Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8006546-JVMTI-JSR292.0
Summary: The copy_operands() does the same copy frrom dest cpool twice in two places. Instead, it must copy once from dest and once from source cpool. It would make it consistent with the comments.
Testing: nsk.jvmti.testlist, nsk.jdi.testlist, nsk.jdwp.testlist, vm/mlvm/indy/func/jvmti/redefineClassInBootstrap
Thanks, Serguei
- Previous message: Review Request (S) 8006542: JSR 292: the VM_RedefineClasses::append_entry() must support invokedynamic entry kinds
- Next message: Review Request (XS) 8006546: JSR 292: typos in the ConstantPool::copy_cp_impl()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]