Review Request (XS) 8006546: JSR 292: typos in the ConstantPool::copy_cp_impl() (original) (raw)
Coleen Phillimore coleen.phillimore at oracle.com
Mon Jan 28 15:55:14 PST 2013
- Previous message: Review Request (XS) 8006546: JSR 292: typos in the ConstantPool::copy_cp_impl()
- Next message: Review Request (XS) 8006546: JSR 292: typos in the ConstantPool::copy_cp_impl()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
This looks good. I assume that this is tested with the mlvm nsk tests? Thanks, Coleen
On 1/28/2013 5:33 PM, serguei.spitsyn at oracle.com wrote:
Please, review the fix for (it was already reviewed by Christian): https://jbs.oracle.com/bugs/browse/JDK-8006546
Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8006546-JVMTI-JSR292.0
Summary: The copyoperands() does the same copy frrom dest cpool twice in two places. Instead, it must copy once from dest and once from source cpool. It would make it consistent with the comments. Testing: nsk.jvmti.testlist, nsk.jdi.testlist, nsk.jdwp.testlist, vm/mlvm/indy/func/jvmti/redefineClassInBootstrap Thanks, Serguei
- Previous message: Review Request (XS) 8006546: JSR 292: typos in the ConstantPool::copy_cp_impl()
- Next message: Review Request (XS) 8006546: JSR 292: typos in the ConstantPool::copy_cp_impl()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]