RFR JDK-8207790: [lworld] update reflection to generate ValueTypes attribute (original) (raw)
mandy chung mandy.chung at oracle.com
Wed Jul 18 19:14:06 UTC 2018
- Previous message (by thread): RFR: version specific class file parser and verifier fixes
- Next message (by thread): RFR JDK-8207790: [lworld] update reflection to generate ValueTypes attribute
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8207790/webrev.00/
The reflection class file generator is so old. We should replace it with ASM. Or maybe time to consider implementing core reflection with method handles. I can't resist to remove the duplicated CP entries (in a limited form in this patch, just the parameter types in the descriptor and declared value types). We can look at the performance impact due to the new Map and Set added in the future. This patch also fixes InnerClassLambdaMetafactory to add the element type to the ValueTypes attributes if it's an array type.
I have verified locally on valhalla tests and currently running tier1 tests. I will write more tests for MH and reflection w.r.t. the value types consistency check to ensure all cases covered.
Mandy [1] http://mail.openjdk.java.net/pipermail/valhalla-dev/2018-July/004728.html
- Previous message (by thread): RFR: version specific class file parser and verifier fixes
- Next message (by thread): RFR JDK-8207790: [lworld] update reflection to generate ValueTypes attribute
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]