Issue 16451: Remove duplication between slice_indices and compute_slice_indices (original) (raw)
Issue16451
Created on 2012-11-10 14:57 by mark.dickinson, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | |||
|---|---|---|---|
| File name | Uploaded | Description | Edit |
| issue16451.patch | mark.dickinson,2012-11-12 20:52 | review |
| Messages (3) | ||
|---|---|---|
| msg175281 - (view) | Author: Mark Dickinson (mark.dickinson) *  |
Date: 2012-11-10 14:57 |
| (From #14794 ...) compute_slice_indices in Objects/rangeobject.c and slice_indices in Objects/sliceobject.c implement essentially the same algorithm. It would be nice to refactor to avoid the repetition. | ||
| msg175473 - (view) | Author: Mark Dickinson (mark.dickinson) * |
Date: 2012-11-12 20:52 |
| Patch attached. | ||
| msg175797 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2012-11-17 19:18 |
| New changeset e9af9b1ca67e by Mark Dickinson in branch 'default': Issue #16451: Refactor to remove duplication between range and slice in slice index computations. http://hg.python.org/cpython/rev/e9af9b1ca67e |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:38 | admin | set | github: 60655 |
| 2012-11-17 19:22:43 | mark.dickinson | set | status: open -> closedresolution: fixed |
| 2012-11-17 19🔞28 | python-dev | set | nosy: + python-devmessages: + |
| 2012-11-12 20:52:32 | mark.dickinson | set | files: + issue16451.patchkeywords: + patchmessages: + |
| 2012-11-12 07:39:11 | mark.dickinson | set | assignee: mark.dickinson |
| 2012-11-10 14:58:03 | mark.dickinson | set | nosy: + serhiy.storchakastage: needs patch |
| 2012-11-10 14:57:31 | mark.dickinson | create |