original ) (raw )Created on 2013-06-11 20:45 by brett.cannon , last changed 2022-04-11 14:57 by admin . This issue is now closed .
Messages (7)
msg190982 - (view) Author: Brett Cannon (brett.cannon) *
Date: 2013-06-11 20:45
For convenience it should live directly off of importlib and not importlib.util.
msg191070 - (view) Author: Berker Peksag (berker.peksag) *
Date: 2013-06-13 09:38
Here's a patch. Changes: - Used types.ModuleType instead of type(sys) - Updated imp and importlib docs - Moved test_imp.ReloadTests to test_importlib.test_api.ReloadTests
msg191140 - (view) Author: Berker Peksag (berker.peksag) *
Date: 2013-06-14 16:30
Updated patch adressing Brett's comments.
msg191141 - (view) Author: Brett Cannon (brett.cannon) *
Date: 2013-06-14 16:55
Answered Berker's questions from the review. At this point Berker just needs to tweak one line in the test and it should then be good to go.
msg191142 - (view) Author: Brett Cannon (brett.cannon) *
Date: 2013-06-14 17:41
With Berker's nice use of TestCase.subTest() I think the patch is good to go! I should hopefully get this checked in today or tomorrow.
msg191144 - (view) Author: Roundup Robot (python-dev)
Date: 2013-06-14 19:04
New changeset 01da7bf11ca1 by Brett Cannon in branch 'default': Issue #18193 : Add importlib.reload(), documenting (but not http://hg.python.org/cpython/rev/01da7bf11ca1
msg191145 - (view) Author: Brett Cannon (brett.cannon) *
Date: 2013-06-14 19:06
Thanks for the patch, Berker!
History
Date
User
Action
Args
2022-04-11 14:57:46
admin
set
github: 62393
2013-06-14 19:06:02
brett.cannon
set
status: open -> closedassignee: brett.cannon messages: + stage: commit review -> resolved
2013-06-14 19:04:36
python-dev
set
status: pending -> opennosy: + python-dev messages: +
2013-06-14 17:41:55
brett.cannon
set
status: open -> pendingresolution: fixedmessages: + stage: patch review -> commit review
2013-06-14 17:36:09
berker.peksag
set
files: + issue18193_v3.diff
2013-06-14 16:55:06
brett.cannon
set
messages: +
2013-06-14 16:30:27
berker.peksag
set
files: + issue18193_v2.diff messages: +
2013-06-13 09:38:35
berker.peksag
set
files: + issue18193.diff nosy: + berker.peksag messages: + keywords: + patch stage: test needed -> patch review
2013-06-11 22:06:24
Arfrever
set
nosy: + Arfrever
2013-06-11 20:45:25
brett.cannon
link
issue17177 dependencies
2013-06-11 20:45:11
brett.cannon
create
