Kaveh R. Ghazi - Re: [PATCH] Use C99 isfinite macro instead of finite when availab (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: "Kaveh R. Ghazi"
• To: tobias dot schlueter at physik dot uni-muenchen dot de
• Cc: dave at hiauly1 dot hia dot nrc dot ca, fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org, stevenb at suse dot de
• Date: Mon, 27 Sep 2004 20:38:10 -0400 (EDT)
• Subject: Re: [PATCH] Use C99 isfinite macro instead of finite when availab
• References: <200409271507.i8RF7vjF016150@hiauly1.hia.nrc.ca> <4158330E.9070408@physik.uni-muenchen.de> <200409271551.i8RFpc53005843@caip.rutgers.edu> <41583A48.5080404@physik.uni-muenchen.de>

But isn't `isfinite' often (always?) a macro? I thought AC_CHECK_FUNCS won't find things if they're only a macro and not in some library as a real function.

I don't know. I just followed the template I found in configure.ac, as noone more knowledgeable about autoconf stepped forward to do this. Can you write a foolproof autoconf test? (Just checking for '#ifdef isfinite' was rejected by Steven up-thread) Thanks,

• Tobi

I think "rejected" is too strong of a wording. Looking back here, http://gcc.gnu.org/ml/gcc-patches/2004-08/msg01747.html Steven "wondered" (as-in posed the question) whether we should have a configure check.

Generally in GCC we don't work by fiat, we try to find the correct solution. If using AC_CHECK_FUNCS turns out to be wrong, then we don't use it.

IMHO, the original patch here: http://gcc.gnu.org/ml/gcc-patches/2004-08/msg00962.html was correct given that isfinite is a macro not a function (if I'm correct that AC_CHECK_FUNCS doesn't detect macros.)

Steven - do you have any objection?

    --Kaveh

-- Kaveh R. Ghazi ghazi@caip.rutgers.edu

• References:
  • Re: [PATCH] Use C99 isfinite macro instead of finite when availab
    * From: John David Anglin
  • Re: [PATCH] Use C99 isfinite macro instead of finite when availab
    * From: Tobias Schlüter
  • Re: [PATCH] Use C99 isfinite macro instead of finite when availab
    * From: Kaveh R. Ghazi
  • Re: [PATCH] Use C99 isfinite macro instead of finite when availab
    * From: Tobias Schlüter