[llvm-dev] [PATCH for-next 7/9] coverage: introduce support for llvm profiling (original) (raw)
Jan Beulich via llvm-dev llvm-dev at lists.llvm.org
Wed Nov 8 03:08:52 PST 2017
- Previous message: [llvm-dev] [PATCH for-next 7/9] coverage: introduce support for llvm profiling
- Next message: [llvm-dev] Is it ok to allocate > half of address space?
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 08.11.17 at 09:56, <roger.pau at citrix.com> wrote: On Wed, Nov 08, 2017 at 01:38:59AM -0700, Jan Beulich wrote: >>> On 26.10.17 at 11:19, <roger.pau at citrix.com> wrote: > --- a/xen/include/public/sysctl.h > +++ b/xen/include/public/sysctl.h > @@ -646,6 +646,12 @@ struct xensysctlschedulerop { > > #define XENGCOVFORMATMAGIC 0x58434f56 /* XCOV */
Hmm, shouldn't the private magic #define-s actually be put here (in which case you'd indeed need to retain both 32- and 64-bit variants)? I don't think so, here XENGCOVFORMATMAGIC is a Xen specific gcov magic number. OTOH LLVMPROFILEMAGIC{64/32} is an llvm defined magic number, that's not under our control. Hence I don't think it should be exported in Xen public headers.
Okay.
Jan
- Previous message: [llvm-dev] [PATCH for-next 7/9] coverage: introduce support for llvm profiling
- Next message: [llvm-dev] Is it ok to allocate > half of address space?
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]