[llvm-dev] [GlobalISel][AArch64] Toward flipping the switch for O0: Please give it a try! (original) (raw)

Kristof Beyls via llvm-dev llvm-dev at lists.llvm.org
Mon Nov 20 02:56:38 PST 2017

On 17 Nov 2017, at 22:51, Justin Bogner <mail at justinbogner.com<mailto:mail at justinbogner.com>> wrote:

Justin Bogner <mail at justinbogner.com<mailto:mail at justinbogner.com>> writes: Kristof Beyls via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> writes: On 13 Nov 2017, at 18:26, Quentin Colombet <qcolombet at apple.com<mailto:qcolombet at apple.com>> wrote: Hi Kristof,

On Nov 13, 2017, at 9:10 AM, Kristof Beyls <Kristof.Beyls at arm.com<mailto:Kristof.Beyls at arm.com>> wrote: Hi Quentin,

My only remaining concern is around ABI compatibility. The following commit seems to indicate that in the previous round of evaluation, we didn’t find an existing ABI compatibility issue: http://llvm.org/viewvc/llvm-project?view=revision&revision=311388. I haven’t looked into the details of this issue - so maybe I’m worried over nothing?

No, you’re right. The problem with ABI is if you are consistently wrong, then you won’t notice :).

I’m wondering if since then on your side you did any testing around ABI compatibility? E.g. building software where you semi-randomly build some functions through GlobalISel and some functions through DAGISel?

Justin will look into that. Clang has utility script for that utils/ ABITest.

Given we will only be able to check iOS ABI, you may want to follow the same kind of validation on your side.

Looping back here, I generated and ran 1000000 test cases with the ABITest utility and hit some fallbacks and an "invalid zero-sized type" assert that need looking at, but it didn't uncover any ABI issues.

Hi Justin,

I followed the instructions you provided earlier in the thread to get these tests running on linux. I also had to change the “#!/bin/sh” lines in the script to “#!/bin/bash”, as apparently the shell scripts in there rely on some bash-isms.

I ran 10000 test cases and didn’t find ABI issues in those; but also found the same “invalid zero-size type” assert. I’ve file a PR at https://bugs.llvm.org/show_bug.cgi?id=35358 for that assert and linked it to the umbrella issue https://bugs.llvm.org/show_bug.cgi?id=35347.

Thanks!

Kristof -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20171120/35ae506c/attachment.html>

More information about the llvm-dev mailing list