[llvm-dev] ABI Breaking Checks (original) (raw)
David Blaikie via llvm-dev llvm-dev at lists.llvm.org
Tue Nov 28 14:35:44 PST 2017
- Previous message: [llvm-dev] LLVM buildmaster is back to work now but two builders remain OFF
- Next message: [llvm-dev] ABI Breaking Checks
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
The abi-breaking.h seems to be incompatible with modules, owing to it having strong definitions in the header.
I'm wondering if I can make it compatible by changing the:
attribute((weak, visibility("hidden"))) variables to attribute((used)) static variables instead? It still seems to produce the desired link errors in my basic tests. Does that seem plausible to you?
(modules have a special case for static variables in headers to support things like the iostreams initializer)
Not sure why the modules buildbots don't see this but google's internal build system building with modules does...
- Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20171128/20511715/attachment.html>
- Previous message: [llvm-dev] LLVM buildmaster is back to work now but two builders remain OFF
- Next message: [llvm-dev] ABI Breaking Checks
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]