[llvm-dev] arc patch with the new git workflow (original) (raw)

Nicolas Lesser via llvm-dev llvm-dev at lists.llvm.org
Fri Feb 8 12:10:57 PST 2019


Unless of course arc patch doesn't use the current directory as patch point! Thank you.

On Fri, Feb 8, 2019 at 9:07 PM Nicolas Lesser <blitzrakete at gmail.com> wrote:

Hi,

On Fri, Feb 8, 2019 at 8:41 PM Mehdi AMINI <joker.eph at gmail.com> wrote:

Are you trying to apply a revision that was uploaded to Phabricator from one of the individual repository (or from SVN)?

Yes from clang if I understood your question correctly. The issue if I remember correctly is that a patch uploaded from an SVN checkout would not start with llvm/ or clang/ and wouldn't be able to be applied in the monorepo. Conversely, a revision created from the monorepo can't be applied by arc patch in a single subproject checkout. I don't think there is a way around this, maybe --strip-prefix and --add-prefix options could be added to arc patch, but I'm not sure it would fit the expectation of arc upstream. That's what I thought too, but doing arc patch either in llvm-project/ or in llvm-project/clang/ doesn't change anything. Thanks again, - Nicolas -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190208/b79aad9f/attachment.html>



More information about the llvm-dev mailing list