Review request for 6927486: Deadlock in legacy Hashtable writeObject() (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Mon Jan 10 12:33:49 UTC 2011

Neil Richards wrote:

: Okay. I've updated the changeset to do this too, and attached this as a webrev zip file (as per Dalibor's suggestion).

Please review this modified changeset, and let me know if anything further is required for its acceptance. Looks fine to me. As per the tests for the Vector serialization, you might want to check the format of the date range in the headers.

I hate bringing up code style/conventions (as it only starts wars) but you might want to check the "implements Serializable" at L76 of SerializationDeadlock.java as it looks like it's not indented. Same thing with the "throws IOException" as line 82. I can't tell from the webrev if this is due to tabs or something else but I noticed it in the webrev for the Vector fix too.

: I did post an update which added the appropriate headers here:

http://mail.openjdk.java.net/pipermail/core-libs-dev/2010-December/005529.html I didn't see that one, sorry. Anyway, I think Mike is going help get these pushed.

-Alan

More information about the core-libs-dev mailing list