Review request for 6927486: Deadlock in legacy Hashtable writeObject() (original) (raw)
Neil Richards neil.richards at ngmr.net
Wed Jan 12 11:22:04 UTC 2011
- Previous message: Review request for 6927486: Deadlock in legacy Hashtable writeObject()
- Next message: hg: jdk7/tl/jdk: 7010537: javah no longer depends on javadoc
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 10 January 2011 12:33, Alan Bateman <Alan.Bateman at oracle.com> wrote:
I hate bringing up code style/conventions (as it only starts wars) but you might want to check the "implements Serializable" at L76 of SerializationDeadlock.java as it looks like it's not indented. Same thing with the "throws IOException" as line 82. I can't tell from the webrev if this is due to tabs or something else but I noticed it in the webrev for the Vector fix too.
Please find attached a new and improved webrev zip file with:
- Amended, consistent indentation
- Use of the diamond operator were applicable
- GPL headers in testcases (ie. "Classpath" exception removed)
- Corrected formatting of copyright statement in testcases
Hopefully it's now hot to trot (aka good to go).
Please let me know if you see anything else, Thanks, Neil
-- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU -------------- next part -------------- A non-text attachment was scrubbed... Name: webrev.6927486.2.zip Type: application/zip Size: 115696 bytes Desc: not available URL: <http://mail.openjdk.java.net/pipermail/core-libs-dev/attachments/20110112/fa708423/webrev.6927486.2.zip>
- Previous message: Review request for 6927486: Deadlock in legacy Hashtable writeObject()
- Next message: hg: jdk7/tl/jdk: 7010537: javah no longer depends on javadoc
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]