PING: [PATCH FOR REVIEW] System Zlib Support (original) (raw)

Xueming Shen xueming.shen at oracle.com
Fri Aug 3 20:57:55 UTC 2012

Andrew,

I just pushed 7188852. Is it possible for you to update your webrev with this change? I would like to try a full build (and regression tests) on your final bits to make sure we don't break the build.

-Sherman

On 08/03/2012 11:33 AM, Andrew Hughes wrote:

----- Original Message -----

----- Original Message ----- On 03/08/2012 16:58, Andrew Hughes wrote:

: It's what we've had for years, and was added orthogonally to 8 in: changeset: 5118:d45bc4307996 user: michaelm date: Tue Mar 06 20:34:38 2012 +0000 summary: 7113349: Initial changeset for Macosx port to jdk though that version is broken (at least on GNU/Linux) without the change to defines.h I posted in my patch earlier this week. Right, that change was for Mac and it didn't have the goal to enable it on Linux. BTW: Looking at your patch then I suspect it will cause problems on other platforms as it only sets ZLIBLIBS in jdkgenericprofile.sh. If folks aren't using this script to setup their environment then I'm sure there will be a problem on Mac at least. I don't have time to spend on it but I suspect Defs-macosx.gmk will need to be updated to make it the default as it does now. I think that's what Sherman just hit. I thought the documented way to build was using jdkgenericprofile.sh? I can add a check to Defs-macosx.gmk. http://cr.openjdk.java.net/~andrew/syslibs/zlib/webrev.02/ is an updated version which checks if ZLIBLIBS is set on Solaris, GNU/Linux and MacOS X and sets it to -lz if not. I wasn't sure what to do with Windows but something can be added there if necessary.

More information about the core-libs-dev mailing list