PING: [PATCH FOR REVIEW] System Zlib Support (original) (raw)

Andrew Hughes ahughes at redhat.com
Mon Aug 6 12:11:44 UTC 2012

----- Original Message -----

Andrew,

I just pushed 7188852. Is it possible for you to update your webrev with this change? I would like to try a full build (and regression tests) on your final bits to make sure we don't break the build.

Do you mean the ZLIB_LIBS changes? I already published an updated webrev;

-Sherman > On 08/03/2012 11:33 AM, Andrew Hughes wrote: > ----- Original Message ----- >> >> ----- Original Message ----- >>> On 03/08/2012 16:58, Andrew Hughes wrote: >>> >>> : It's what we've had for years, and was added orthogonally to 8 >>> in: >>> >>> changeset: 5118:d45bc4307996 >>> user: michaelm >>> date: Tue Mar 06 20:34:38 2012 +0000 >>> summary: 7113349: Initial changeset for Macosx port to jdk >>> >>> though that version is broken (at least on GNU/Linux) without the >>> change >>> to defines.h I posted in my patch earlier this week. Right, that >>> change was for Mac and it didn't have the goal to enable it on >>> Linux. >>> >>> BTW: Looking at your patch then I suspect it will cause problems >>> on >>> other platforms as it only sets ZLIBLIBS in >>> jdkgenericprofile.sh. >>> If folks aren't using this script to setup their environment then >>> I'm sure there will be a problem on Mac at least. I don't have >>> time >>> to spend on it but I suspect Defs-macosx.gmk will need to be >>> updated >>> to make it the default as it does now. >>> >> I think that's what Sherman just hit. >> >> I thought the documented way to build was using >> jdkgenericprofile.sh? >> I can add a check to Defs-macosx.gmk. >> > http://cr.openjdk.java.net/~andrew/syslibs/zlib/webrev.02/ > > is an updated version which checks if ZLIBLIBS is set on Solaris, > GNU/Linux > and MacOS X and sets it to -lz if not. > > I wasn't sure what to do with Windows but something can be added > there if necessary. >

Andrew :)

Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07

More information about the core-libs-dev mailing list