Request for review for [JBS] (JDK-8004212) java.util.Base64 methods decodeArray and decodeBuffer should return the number of bytes written (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Sat Dec 1 15:58:20 UTC 2012
- Previous message: Request for review (XXS): JDK-8004066: TEST_BUG: test/java/lang/Math/DivModTests.java assumes ArithmeticException message
- Next message: Request for review for [JBS] (JDK-8004212) java.util.Base64 methods decodeArray and decodeBuffer should return the number of bytes written
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 30/11/2012 21:03, Xueming Shen wrote:
Alan,
It appears the return value is not correct in decode(Bytebuffer...) case if the buffer is overflow. Here is the webrev for that. http://cr.openjdk.java.net/~sherman/8004212/webrev/ I assume you mean the initial position is not 0 rather than overall. In any case, it looks fine to me.
-Alan.
- Previous message: Request for review (XXS): JDK-8004066: TEST_BUG: test/java/lang/Math/DivModTests.java assumes ArithmeticException message
- Next message: Request for review for [JBS] (JDK-8004212) java.util.Base64 methods decodeArray and decodeBuffer should return the number of bytes written
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]