Request for review for [JBS] (JDK-8004212) java.util.Base64 methods decodeArray and decodeBuffer should return the number of bytes written (original) (raw)
Xueming Shen xueming.shen at oracle.com
Sat Dec 1 19:13:38 UTC 2012
- Previous message: Request for review for [JBS] (JDK-8004212) java.util.Base64 methods decodeArray and decodeBuffer should return the number of bytes written
- Next message: hg: jdk8/tl/jdk: 8004212: java.util.Base64 methods decodeArray and decodeBuffer should return the number of bytes written
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
I meant the situation that the initial position is not 0 AND the buffer does not not have enough space to decode all input. If the buffer has enough space, it worked the fine.
-Sherman
On 12/1/12 7:58 AM, Alan Bateman wrote:
On 30/11/2012 21:03, Xueming Shen wrote:
Alan,
It appears the return value is not correct in decode(Bytebuffer...) case if the buffer is overflow. Here is the webrev for that. http://cr.openjdk.java.net/~sherman/8004212/webrev/ I assume you mean the initial position is not 0 rather than overall. In any case, it looks fine to me. -Alan.
- Previous message: Request for review for [JBS] (JDK-8004212) java.util.Base64 methods decodeArray and decodeBuffer should return the number of bytes written
- Next message: hg: jdk8/tl/jdk: 8004212: java.util.Base64 methods decodeArray and decodeBuffer should return the number of bytes written
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]