review request 7172551 (original) (raw)

Joe Darcy joe.darcy at oracle.com
Thu Jun 7 20:39:59 UTC 2012

Generally looks fine, but I recommend some adjustments:

I'd like to see some "()" on this line!

 470         ClassLoader cl = cc != null ? cc.getClassLoader() : null;

I prefer to update the copyright year as part of making the code changes.

-Joe

On 6/7/2012 11:47 AM, Lance Andersen - Oracle wrote:

Hi all,

Another review request (to go with the others that are outstanding). This is change is for jigsaw, where we are removing the native code used by DriverManager. The webrev can be found at: http://cr.openjdk.java.net/~lancea/7172551/webrev.00 Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com

More information about the core-libs-dev mailing list