review request 7172551 (original) (raw)
Tom Hawtin tom.hawtin at oracle.com
Mon Jun 11 12:44:16 UTC 2012
- Previous message: review request 7172551
- Next message: review request 7172551
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 07/06/2012 21:39, Joe Darcy wrote:
I'd like to see some "()" on this line!
470 ClassLoader cl = cc != null ? cc.getClassLoader() : null;
It's a==b ? c : d is such an incredibly common idiom in Java, and
generally unambiguous, that parentheses are unhelpful noise. Emphasising
precedence with spacing is good. And I personally have a strong dislike
of the double negative.
470 ClassLoader cl = cc==null ? null : cc.getClassLoader();
Tom
- Previous message: review request 7172551
- Next message: review request 7172551
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]