Request for Review : 6553074 : String{Buffer, Builder}.indexOf(Str, int) contains unnecessary allocation (original) (raw)
Jim Gish jim.gish at oracle.com
Wed Nov 14 21:24:09 UTC 2012
- Previous message: Request for Review : 6553074 : String{Buffer, Builder}.indexOf(Str, int) contains unnecessary allocation
- Next message: Request for Review : 6553074 : String{Buffer, Builder}.indexOf(Str, int) contains unnecessary allocation
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Mike,
In String.java, with the new methods you're adding, should we make those String target parameters a CharSequence instead?
Thanks, Jim
On 11/14/2012 01:27 PM, Mike Duigou wrote: > Hello all; >> This patch causes the indexOf and lastIndexOf implementation in AbstractStringBuilder to directly compare the character arrays rather than making a copy of the substring before comparing. >> http://cr.openjdk.java.net/~mduigou/6553074/0/webrev/ >>
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304 Oracle Java Platform Group | Core Libraries Team 35 Network Drive Burlington, MA 01803 jim.gish at oracle.com
- Previous message: Request for Review : 6553074 : String{Buffer, Builder}.indexOf(Str, int) contains unnecessary allocation
- Next message: Request for Review : 6553074 : String{Buffer, Builder}.indexOf(Str, int) contains unnecessary allocation
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]