Request for Review : 6553074 : String{Buffer, Builder}.indexOf(Str, int) contains unnecessary allocation (original) (raw)

Mike Duigou mike.duigou at oracle.com
Mon Nov 19 22:09:26 UTC 2012

On Nov 14 2012, at 13:24 , Jim Gish wrote:

Mike,

In String.java, with the new methods you're adding, should we make those String target parameters a CharSequence instead?

A String param enables us to extract the internal char array for the search. We could not do so with a CharSequence and would have to create a substring somewhat like the old implementation did.

Mike

Thanks, Jim

On 11/14/2012 01:27 PM, Mike Duigou wrote: Hello all;

This patch causes the indexOf and lastIndexOf implementation in AbstractStringBuilder to directly compare the character arrays rather than making a copy of the substring before comparing. http://cr.openjdk.java.net/~mduigou/6553074/0/webrev/

More information about the core-libs-dev mailing list