Reviewer needed: 6282196 There should be Math.mod(number, modulo) methods (original) (raw)

Bruce Chapman brucechapman at paradise.net.nz
Fri Oct 12 07:51:51 UTC 2012


And maybe say "round toward" rather than "round to", the first implies a direction, the second implies a destination.

Bruce

On 12/10/2012 1:40 p.m., Joseph Darcy wrote:

Hi Roger,

The changes look fine. However, I suggest adding an explanatory note along the lines of "Normal integer division operates under the round to zero rounding mode (truncation). This operation instead acts under the round to negative infinity (floor) rounding mode. The floor rounding mode gives different results than truncation when the exact result is negative." Thanks, -Joe On 10/10/2012 7:22 AM, Roger Riggs wrote: A reviewer is needed for:

6282196 There should be Math.mod(number, modulo) methods The webrev is: http://cr.openjdk.java.net/~rriggs/6282196.4/ Thanks, Roger



More information about the core-libs-dev mailing list