Reviewer needed: 6282196 There should be Math.mod(number, modulo) methods (original) (raw)
Joseph Darcy joe.darcy at oracle.com
Fri Oct 12 00:40:22 UTC 2012
- Previous message: Reviewer needed: 6282196 There should be Math.mod(number, modulo) methods
- Next message: Reviewer needed: 6282196 There should be Math.mod(number, modulo) methods
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Roger,
The changes look fine. However, I suggest adding an explanatory note along the lines of "Normal integer division operates under the round to zero rounding mode (truncation). This operation instead acts under the round to negative infinity (floor) rounding mode. The floor rounding mode gives different results than truncation when the exact result is negative."
Thanks,
-Joe
On 10/10/2012 7:22 AM, Roger Riggs wrote:
A reviewer is needed for:
6282196 There should be Math.mod(number, modulo) methods The webrev is: http://cr.openjdk.java.net/~rriggs/6282196.4/ Thanks, Roger
- Previous message: Reviewer needed: 6282196 There should be Math.mod(number, modulo) methods
- Next message: Reviewer needed: 6282196 There should be Math.mod(number, modulo) methods
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]