Reviewer needed: 6282196 There should be Math.mod(number, modulo) methods (original) (raw)
Roger Riggs Roger.Riggs at Oracle.com
Sat Oct 13 15:20:42 UTC 2012
- Previous message: Reviewer needed: 6282196 There should be Math.mod(number, modulo) methods
- Next message: Reviewer needed: 6282196 There should be Math.mod(number, modulo) methods
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thanks for pointing out that omission. I will fix the spec and the tests to note the special case as described for the division operator in the JLS.
The other result returning MAX_VALUE from floorDiv(Integer.MIN_VALUE, -1) does not seem any more beneficial.
Thanks, Roger
On 10/10/2012 12:12 PM, Eamonn McManus wrote:
One edge case: the spec for floorDiv implies that floorDiv(Integer.MINVALUE, -1) should be Integer.MAXVALUE but I believe the code produces Integer.MINVALUE. EIther the spec or the code should be fixed.
Éamonn
2012/10/10 Roger Riggs <Roger.Riggs at oracle.com>: A reviewer is needed for:
6282196 There should be Math.mod(number, modulo) methods The webrev is: http://cr.openjdk.java.net/~rriggs/6282196.4/ Thanks, Roger
- Previous message: Reviewer needed: 6282196 There should be Math.mod(number, modulo) methods
- Next message: Reviewer needed: 6282196 There should be Math.mod(number, modulo) methods
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]