Please review: 7194005: (launcher) needs to be enhanced for 64-bit jar file handling (original) (raw)
Kumar Srinivasan kumar.x.srinivasan at oracle.com
Tue Sep 4 17:05:35 UTC 2012
- Previous message: Please review: 7194005: (launcher) needs to be enhanced for 64-bit jar file handling
- Next message: Please review: 7194005: (launcher) needs to be enhanced for 64-bit jar file handling
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Joe,
I was thinking about that too, yes I will make it conditional on a system property or env variable.
Kumar
----- joe.darcy at oracle.com wrote:
From: joe.darcy at oracle.com To: kumar.x.srinivasan at oracle.com Cc: core-libs-dev at openjdk.java.net, xueming.shen at oracle.com, james.holmlund at oracle.com Sent: Tuesday, September 4, 2012 9:50:03 AM GMT -08:00 US/Canada Pacific Subject: Re: Please review: 7194005: (launcher) needs to be enhanced for 64-bit jar file handling
Hi Kumar, From a quick look I didn't seen any problems, but defaulting to running a test that writes multiple gibabytes to disk may have unwanted performance costs for general testing. Perhaps that scenario could be included in the test code, but only run on an opt-in basis? -Joe
On 9/4/2012 6:47 AM, Kumar Srinivasan wrote:
Hi Sherman, Joe, et. al.
Please review the launcher changes to read the manifest of a ZIP64 archive. http://cr.openjdk.java.net/~ksrini/7194005/webrev.0/ Thanks Kumar
- Previous message: Please review: 7194005: (launcher) needs to be enhanced for 64-bit jar file handling
- Next message: Please review: 7194005: (launcher) needs to be enhanced for 64-bit jar file handling
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]