Please review: 7194005: (launcher) needs to be enhanced for 64-bit jar file handling (original) (raw)

Xueming Shen xueming.shen at oracle.com
Tue Sep 4 17:49:37 UTC 2012

Kumar,

The change looks fine with me. Agreed that you definitely don't want to run the auto test for a > 4G file. The >4G test in zip/jar area was checked in as a manual test.

Just wonder you might want to consider to use (statically include, like you do for those zlib code) the zip_util/ZIP_Open/FineEntry/ReadEntry instead of having your own zip format handling code in launcher (source). Not necessary for this patch.

-Sherman

On 09/04/2012 10:05 AM, Kumar Srinivasan wrote:

Hi Joe,

I was thinking about that too, yes I will make it conditional on a system property or env variable. Kumar ----- joe.darcy at oracle.com wrote: > From: joe.darcy at oracle.com > To: kumar.x.srinivasan at oracle.com > Cc: core-libs-dev at openjdk.java.net, xueming.shen at oracle.com, james.holmlund at oracle.com > Sent: Tuesday, September 4, 2012 9:50:03 AM GMT -08:00 US/Canada Pacific > Subject: Re: Please review: 7194005: (launcher) needs to be enhanced for 64-bit jar file handling > > Hi Kumar, > > From a quick look I didn't seen any problems, but defaulting to running a test that writes multiple gibabytes to disk may have unwanted performance costs for general testing. Perhaps that scenario could be included in the test code, but only run on an opt-in basis? > > -Joe > > > On 9/4/2012 6:47 AM, Kumar Srinivasan wrote: > > Hi Sherman, Joe, et. al. > > Please review the launcher changes to read the manifest of > a ZIP64 archive. > > http://cr.openjdk.java.net/~ksrini/7194005/webrev.0/ > > Thanks > Kumar > > >

>

More information about the core-libs-dev mailing list