Code review request for 6298888 (reflect) Add toGenericString to java.lang.Class and java.lang.reflect.Type (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Fri Apr 5 12:46:13 UTC 2013
- Previous message: Code review request for 6298888 (reflect) Add toGenericString to java.lang.Class and java.lang.reflect.Type
- Next message: Code review request for 6298888 (reflect) Add toGenericString to java.lang.Class and java.lang.reflect.Type
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 03/04/2013 17:38, Joe Darcy wrote:
Hi Peter,
On 04/03/2013 01:26 AM, Peter Levart wrote: Hi Joe,
Why not using StringBuilder instead of StringBuffer in Class.toGenericString ? No reason. Thanks for catching this; I'll use StringBuilder in the final push. Modifier.toString can probably be updated too.
I looked through the changes and they look okay to me. For the toGenericString javadoc then "formatted as a list" might be better than "formatted as list".
-Alan
- Previous message: Code review request for 6298888 (reflect) Add toGenericString to java.lang.Class and java.lang.reflect.Type
- Next message: Code review request for 6298888 (reflect) Add toGenericString to java.lang.Class and java.lang.reflect.Type
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]