Code review request for 6298888 (reflect) Add toGenericString to java.lang.Class and java.lang.reflect.Type (original) (raw)
Joe Darcy joe.darcy at oracle.com
Fri Apr 5 18:39:36 UTC 2013
- Previous message: Code review request for 6298888 (reflect) Add toGenericString to java.lang.Class and java.lang.reflect.Type
- Next message: [OpenJDK 2D-Dev] sun.java2D.pisces big memory usage (waste ?)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 04/05/2013 05:46 AM, Alan Bateman wrote:
On 03/04/2013 17:38, Joe Darcy wrote:
Hi Peter,
On 04/03/2013 01:26 AM, Peter Levart wrote: Hi Joe,
Why not using StringBuilder instead of StringBuffer in Class.toGenericString ? No reason. Thanks for catching this; I'll use StringBuilder in the final push. Modifier.toString can probably be updated too.
Will do.
I looked through the changes and they look okay to me. For the toGenericString javadoc then "formatted as a list" might be better than "formatted as list".
I'll correct that as well.
Thanks Alan,
-Joe
- Previous message: Code review request for 6298888 (reflect) Add toGenericString to java.lang.Class and java.lang.reflect.Type
- Next message: [OpenJDK 2D-Dev] sun.java2D.pisces big memory usage (waste ?)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]