RFR (XS) 8008089: Delete OS dependent check in JdkFinder.getExecutable() (original) (raw)
Yekaterina Kantserova yekaterina.kantserova at oracle.com
Wed Feb 13 09:47:32 UTC 2013
- Previous message: hg: jdk8/tl/langtools: 8007279: Rename javax.l.model.element.Element.getAnnotations(Class) to getAnnotationsByType(Class)
- Next message: RFR (XS) 8008089: Delete OS dependent check in JdkFinder.getExecutable()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi everyone,
This small fixconcerns jdk.testlibrary.JdkFinder utility class. The check below is too OS dependent and should be deleted. ... binPath += File.separatorChar + "bin" + File.separatorChar + executable; File toolFile = new File(binPath); ==> if (!toolFile.exists()) { throw new RuntimeException(binPath + " does not exist"); } ...
On windows if executable is specified as e.g. 'java', without '.exe', the File exists() will fail. But it's still possible to run executable.
Webrev: http://cr.openjdk.java.net/~ykantser/8008089/webrev.00/
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008089
Testing: JPRT
Thanks, Katja
- Previous message: hg: jdk8/tl/langtools: 8007279: Rename javax.l.model.element.Element.getAnnotations(Class) to getAnnotationsByType(Class)
- Next message: RFR (XS) 8008089: Delete OS dependent check in JdkFinder.getExecutable()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]