RFR (XS) 8008089: Delete OS dependent check in JdkFinder.getExecutable() (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Tue Feb 19 16:01:46 UTC 2013
- Previous message: RFR (XS) 8008089: Delete OS dependent check in JdkFinder.getExecutable()
- Next message: RFR (XS) 8008089: Delete OS dependent check in JdkFinder.getExecutable()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 13/02/2013 09:47, Yekaterina Kantserova wrote:
Hi everyone,
This small fixconcerns jdk.testlibrary.JdkFinder utility class. The check below is too OS dependent and should be deleted. ... binPath += File.separatorChar + "bin" + File.separatorChar + executable; File toolFile = new File(binPath); ==> if (!toolFile.exists()) { throw new RuntimeException(binPath + " does not exist"); } ... On windows if executable is specified as e.g. 'java', without '.exe', the File exists() will fail. But it's still possible to run executable. This looks okay to me, do you have someone to push this for you?
-Alan.
- Previous message: RFR (XS) 8008089: Delete OS dependent check in JdkFinder.getExecutable()
- Next message: RFR (XS) 8008089: Delete OS dependent check in JdkFinder.getExecutable()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]