Do not let internal JDK zlib symbols leak out of fastdebug libzip.so (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Thu Feb 28 14:03:23 UTC 2013
- Previous message: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so
- Next message: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 27/02/2013 23:16, Martin Buchholz wrote:
I have another iteration of this change http://cr.openjdk.java.net/~martin/webrevs/openjdk8/hide-zlib/ <http://cr.openjdk.java.net/%7Emartin/webrevs/openjdk8/hide-zlib/> that adds exciting new exception detail message for the InternalError I was scratching my head about earlier.
- msg = strm->msg; + msg = ((strm->msg != NULL) ? strm->msg : + (ret == ZVERSIONERROR) ? + "zlib returned ZVERSIONERROR: " + "compile time and runtime zlib implementations differ" : + (ret == ZSTREAMERROR) ? + "inflateInit2 returned ZSTREAMERROR" : + "unknown error initializing zlib library"); The update to make/java/zip/Makefile looks good to me, we should have done it a long time ago. I assume you are pushing ahead on this because you want to push it to jdk7u-dev (as it's not interesting to jdk8 now because of the new build).
The exciting new exception detail change looks okay to me too although it is hard to read. It wasn't immediately obvious to me why stddef.h was needed and we'd need to make sure that is okay on all platforms.
-Alan.
- Previous message: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so
- Next message: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]