Do not let internal JDK zlib symbols leak out of fastdebug libzip.so (original) (raw)
Martin Buchholz martinrb at google.com
Thu Feb 28 16:11:45 UTC 2013
- Previous message: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so
- Next message: Code review request
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Thu, Feb 28, 2013 at 6:03 AM, Alan Bateman <Alan.Bateman at oracle.com>wrote:
The update to make/java/zip/Makefile looks good to me, we should have done it a long time ago. I assume you are pushing ahead on this because you want to push it to jdk7u-dev (as it's not interesting to jdk8 now because of the new build).
Yes I'm hoping you push this fix to jdk7u.
Also, I'm not sure that the new build system will not try to be bug-for-bug compatible with the old one and will reintroduce the problem.
The exciting new exception detail change looks okay to me too although it is hard to read. It wasn't immediately obvious to me why stddef.h was needed and we'd need to make sure that is okay on all platforms.
It's hard to find something more standard than stddef.h.
"Include What You Use" ==> "always #include <stddef.h> in any source file that uses NULL."
- Previous message: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so
- Next message: Code review request
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]