RFR (S) CR 8016236: Class.getGenericInterfaces performance improvement (original) (raw)

Peter Levart peter.levart at gmail.com
Mon Jun 17 06:06:04 UTC 2013

On 06/16/2013 09:44 PM, Alan Bateman wrote:

On 13/06/2013 12:47, Aleksey Shipilev wrote:

Friendly reminder for the reviewers.

On 06/10/2013 07:53 PM, Aleksey Shipilev wrote: This is the follow-up on the issue Doug identified: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/017798.html

I had reworked the patch, webrev is here: http://cr.openjdk.java.net/~shade/8016236/webrev.01/ The current webrev is here: http://cr.openjdk.java.net/~shade/8016236/webrev.02/ I'm just catching up on this thread, webrev.02 looks very good to me. I can sponsor it. One comment on ClassRepositoryHolder is that it's "yet another class" (we have a proliferation of holder classes since we started using this idiom). It makes me wonder if it might be better to move the constant to ClassRepository.

That's a good idea. Since it's in a package different from java.lang, the field would have to be public. So perhaps a chain of no-arg constructors could be used to construct such instance which would be unusable for any purpose other than identity comparison.

Peter

-Alan.

More information about the core-libs-dev mailing list