[9] RFR (M): 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke (original) (raw)
Vladimir Ivanov vladimir.x.ivanov at oracle.com
Fri Jul 11 10:34:18 UTC 2014
- Previous message: [9] RFR (M): 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke
- Next message: [9] RFR (M): 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
http://cr.openjdk.java.net/~vlivanov/8049555/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8049555
Code cleanup: - moved varargsArray(Class,int) & varargsArray(int) from sun.invoke.util.ValueConversions to java.lang.invoke.MethodHandleImpl; - removed unused varargsList(int); MethodHandleImpl.convertArrayElements (copied over from sun.invoke.util.ValueConversions) is also not used, do you wanna keep then one? Good catch I have it removed in the very next patch, but I'll move it here.
- extracted relevant tests from ValueConversionsTest to VarargsArrayTest.
That's an interesting trick to get things working on the bootclasspath: 36 * @run main ClassFileInstaller java.lang.invoke.VarargsArrayTest 37 * java.lang.invoke.VarargsArrayTest$1 Where does "java.lang.invoke.VarargsArrayTest$1" comes from? If it does not exist i would presume an NPE would occur causing the test to fail on setup? VarargsArrayTest$1 is generated for switch over Wrapper enum in toArrayString.
Best regards, Vladimir Ivanov
- Previous message: [9] RFR (M): 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke
- Next message: [9] RFR (M): 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]