[9] RFR (M): 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke (original) (raw)

Igor Ignatyev igor.ignatyev at oracle.com
Fri Jul 11 11:56:57 UTC 2014

Vladimir,

instead of the trick w/ 'ClassFileInstaller', you can use 'bootclasspath' option[1] which adds all paths to the bootclasspath:

* @run main/bootclasspath java.lang.invoke.VarargsArrayTest * @run main/bootclasspath * -DVarargsArrayTest.MAXARITY=255 -DVarargsArrayTest.STARTARITY=250 * java.lang.invoke.VarargsArrayTest

[1] http://hg.openjdk.java.net/code-tools/jtreg/file/jtreg4.1-b07/src/share/classes/com/sun/javatest/regtest/MainAction.java#l131 [2] http://hg.openjdk.java.net/code-tools/jtreg/file/jtreg4.1-b07/src/share/classes/com/sun/javatest/regtest/MainAction.java#l343

Igor

On 07/11/2014 02:34 PM, Vladimir Ivanov wrote:

>> http://cr.openjdk.java.net/~vlivanov/8049555/webrev.00/

https://bugs.openjdk.java.net/browse/JDK-8049555

Code cleanup: - moved varargsArray(Class,int) & varargsArray(int) from sun.invoke.util.ValueConversions to java.lang.invoke.MethodHandleImpl; - removed unused varargsList(int); MethodHandleImpl.convertArrayElements (copied over from sun.invoke.util.ValueConversions) is also not used, do you wanna keep then one? Good catch I have it removed in the very next patch, but I'll move it here. - extracted relevant tests from ValueConversionsTest to VarargsArrayTest.

That's an interesting trick to get things working on the bootclasspath: 36 * @run main ClassFileInstaller java.lang.invoke.VarargsArrayTest 37 * java.lang.invoke.VarargsArrayTest$1 Where does "java.lang.invoke.VarargsArrayTest$1" comes from? If it does not exist i would presume an NPE would occur causing the test to fail on setup? VarargsArrayTest$1 is generated for switch over Wrapper enum in toArrayString. Best regards, Vladimir Ivanov

mlvm-dev mailing list mlvm-dev at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev

More information about the core-libs-dev mailing list