RFR 8209184: JDK8 ResourceBundle vulnerable to GC (fix included) (original) (raw)
mandy chung mandy.chung at oracle.com
Thu Aug 16 17:57:01 UTC 2018
- Previous message: RFR 8209184: JDK8 ResourceBundle vulnerable to GC (fix included)
- Next message: RFR 8209184: JDK8 ResourceBundle vulnerable to GC (fix included)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 8/16/18 2:16 AM, Adam Farley8 wrote:
Hi Mandy,
I request that you review this for 8u. ------------------------------------------------------ @@ -1398,10 +1398,18 @@ bundle = baseBundle; } + keepAlive(loader); return bundle; } /** + * Keeps the argument ClassLoader alive. + */ + private static void keepAlive(ClassLoader loaderone){ + //Do nothing. + } + + /** * Checks if the given
List
is not null, not empty, * not having null in its elements. */ ------------------------------------------------------
Looks fine. Nit: a space before "Do nothing" comment would be good. No need for a new diff.
Mandy
- Previous message: RFR 8209184: JDK8 ResourceBundle vulnerable to GC (fix included)
- Next message: RFR 8209184: JDK8 ResourceBundle vulnerable to GC (fix included)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]