RFR 8209184: JDK8 ResourceBundle vulnerable to GC (fix included) (original) (raw)

Adam Farley8 adam.farley at uk.ibm.com
Fri Aug 17 09:58:34 UTC 2018

Hi Mandy,

The extra space is fine.

In hindsight, you could probably rename "loaderone" to just "loader" too.

Thanks for helping with this. :)

Best Regards

Adam Farley OpenJDK Team Runtimes IBM

mandy chung <mandy.chung at oracle.com> wrote on 16/08/2018 18:57:01:

From: mandy chung <mandy.chung at oracle.com> To: Adam Farley8 <adam.farley at uk.ibm.com> Cc: core-libs-dev <core-libs-dev at openjdk.java.net>, Hans Boehm <hboehm at google.com>, i18n-dev at openjdk.java.net Date: 16/08/2018 18:57 Subject: Re: RFR 8209184: JDK8 ResourceBundle vulnerable to GC (fix included)

On 8/16/18 2:16 AM, Adam Farley8 wrote: > Hi Mandy, > > I request that you review this for 8u. > > ------------------------------------------------------ > @@ -1398,10 +1398,18 @@ > bundle = baseBundle; > } > > + keepAlive(loader); > return bundle; > } > > /** > + * Keeps the argument ClassLoader alive. > + */ > + private static void keepAlive(ClassLoader loaderone){ > + //Do nothing. > + } > + > + /** > * Checks if the given List is not null, not empty, > * not having null in its elements. > */ > ------------------------------------------------------ Looks fine. Nit: a space before "Do nothing" comment would be good. No need for a new diff. Mandy

Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

More information about the core-libs-dev mailing list