RFR (S): add CodeComments functionality to assember stubs (original) (raw)

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Sep 19 05:20:18 PDT 2012

Hi,

The Assembler and CodeBuffer classes supply CodeComment / block_comment() functionality, which does not work with stubs. The comments are not printed with +PrintStubCode or +PrintInterpreter because the comments are lost when the code is turned into a Stub, while they are kept if the code is copied to a CodeBlob.

We fixed this in our SAP JVM, and contributed the change to the ppc-aix-port some while ago, see http://hg.openjdk.java.net/ppc-aix-port/jdk7u/hotspot/rev/d65d0876ab43.

I propose to add this fix to the OpenJDK mainline. A webrev can be found here: http://cr.openjdk.java.net/~goetz/webrevs/webrev-comments_in_stubs/

Basically the change passes the codeBuffer to the Stub constructor, and adapts the disassembler to print the comments. In the debug build the InterpreterCodelet Stub has a new field holding the code comments.

I also added some ttyLocks and \ns<file:///\ns> to beautify the output.

Could somebody please create a bug id for this issue and review the changes?

Thank you and best regards, Goetz

-------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20120919/2c5f4db2/attachment.html

More information about the hotspot-compiler-dev mailing list