RFR (XS): 8035585: Restore UseOldInlining in jdk8u (original) (raw)

Krystal Mok rednaxelafx at gmail.com
Fri Feb 21 12:16:34 PST 2014

Hi Vladimir,

On Fri, Feb 21, 2014 at 12:02 PM, Vladimir Kozlov < vladimir.kozlov at oracle.com> wrote:

On 2/21/14 11:52 AM, Krystal Mok wrote:

Hi Vladimir,

Yes, I've followed Aleksey's post for removing UseOldInling flag. I'm just asking if this flag can be put into the obsoletejvmflags for JDK 8 as well. That way you won't need to add the flag back to globals.hpp. Is it not good because you can't even issue a warning for this flag in JDK 8? Not in Update release. We are talking about 8u20. I see. Then this change looks good to me (not a Reviewer).

There are counter-examples to deprecating flags in a update release, though, e.g. { "Tier1Inline", JDK_Version::jdk_update(7,40), JDK_Version::jdk(8) }, I just though it'd be doable for JDK_Version::jdk_update(8, 20) as well...

Thanks, Kris

Thanks, Vladimir

Thanks, Kris

On Fri, Feb 21, 2014 at 11:39 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com <mailto:vladimir.kozlov at oracle.com>> wrote: Kris, The flag name is deceiving. We only used code with UseOldInlining=true. The code which was removed was under !UseOldInlining (negated). We kept the code which was under UseOldInlining. So the behavior did not changed. And the flag is in deprecated list: + { "UseOldInlining", JDKVersion::jdk(9), JDKVersion::jdk(10) }, Thanks, Vladimir On 2/21/14 11:15 AM, Krystal Mok wrote: Hi Vladimir, Restoring a flag without backing code is a little bit weird. Is is possible to put it in the deprecated flags list instead? Thanks, Kris On Fri, Feb 21, 2014 at 10:41 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com <mailto:vladimir.kozlov at oracle.com> <mailto:vladimir.kozlov at _oracle.com_ _<mailto:vladimir.kozlov at oracle.com>>> wrote: https://bugs.openjdk.java.net/__browse/JDK-8035585 <https://bugs.openjdk.java.net/_browse/JDK-8035585> <https://bugs.openjdk.java._net/browse/JDK-8035585_ _<https://bugs.openjdk.java.net/browse/JDK-8035585>> http://cr.openjdk.java.net/~__kvn/8035585/webrev/ <http://cr.openjdk.java.net/~_kvn/8035585/webrev/> <http://cr.openjdk.java.net/~_kvn/8035585/webrev/_ _<http://cr.openjdk.java.net/~kvn/8035585/webrev/>> I backported 8032490 changes which removed UseOldInlining flags. We can't do that in update release. Restore the flag but keep code changes. The removed code was never used, tested and was rotten. Thanks, Vladimir

-------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140221/76050b49/attachment.html

More information about the hotspot-compiler-dev mailing list