[9] RFR(S): 8130309: need to bailout cleanly if CompiledStaticCall::emit_to_interp_stub fails when codecache is out of space (original) (raw)

Tobias Hartmann tobias.hartmann at oracle.com
Wed Jul 22 08:04:57 UTC 2015

Hi Andrew,

On 22.07.2015 09:47, Andrew Dinn wrote:

Hi Thomas,

The patch looks good so it could be pushed as is as far as I am concerned (not a hotspot/openjdk reviewer).

Thanks for taking a look!

However, note that the ppc port also suffers from the same problem. It employs an identical routine emittrampolinestub defined in the Arch Description file (ppc.ad). You might want to include a tweak to the ppc code as part of this fix or maybe leave it to Volker/Goetz et al.

What problem are you referring to? The actual problem I fixed with this patch is platform independent. It's caused by C2 code not bailing out if the platform dependent code was unable to create a stub (see changes in 'output.cpp'). I only removed the call to 'start_a_stub' in the aarch64 code because it is useless. I don't see this call on ppc though.

Thanks, Tobias

n.b. the problem also affects both the ppc jdk8 code but is not present in AArch64 jdk8. Since the ppc fix probably needs a backport it might be better to leave that fix as a separate step?

regards,

Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in UK and Wales under Company Registration No. 3798903 Directors: Michael Cunningham (USA), Matt Parson (USA), Charlie Peters (USA), Michael O'Neill (Ireland)

More information about the hotspot-compiler-dev mailing list