[9] RFR(S): 8130309: need to bailout cleanly if CompiledStaticCall::emit_to_interp_stub fails when codecache is out of space (original) (raw)

Andrew Dinn adinn at redhat.com
Wed Jul 22 08:32:59 UTC 2015

On 22/07/15 09:04, Tobias Hartmann wrote:

On 22.07.2015 09:47, Andrew Dinn wrote: . . .

However, note that the ppc port also suffers from the same problem. It employs an identical routine emittrampolinestub defined in the Arch Description file (ppc.ad). You might want to include a tweak to the ppc code as part of this fix or maybe leave it to Volker/Goetz et al. What problem are you referring to? The actual problem I fixed with this patch is platform independent. It's caused by C2 code not bailing out if the platform dependent code was unable to create a stub (see changes in 'output.cpp'). I only removed the call to 'startastub' in the aarch64 code because it is useless. I don't see this call on ppc though.

Oops, apologies this is my mistake! The AArch4 code was cloned off the ppc code and I when I looked at the ppc versions this morning I saw they included the same repeated call to start_a_stub that you removed from the AArch64 tree. Evidently I was still high on crack from last night's Dionysian debauch (or something like that :-) since, as you say, there is no such call.

I'll just go get another cup of coffee . . .

regards,

Andrew Dinn

More information about the hotspot-compiler-dev mailing list