RFR [XXS] : Adjust the comment for flag UseAES in globals.hpp (original) (raw)

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Feb 3 17:46:32 UTC 2017


Hi Matthias,

I looked on other flags and I want to remove line 667 too if you are okay with it:

665 product(bool, UseSHA, false,
666 "Control whether SHA instructions can be used "
667 "on SPARC, on ARM and on x86") \

Thanks, Vladimir

On 2/3/17 3:52 AM, Baesken, Matthias wrote:

/Hi Matthias,/

/ / /looks good./

+1

/ / /I'm wondering whether this textual change could still make it into JDK9...?/ Make it P3 and change "Affects" and "Fix" version to 9. Thanks, Vladimir Hi Vladimir, I adjusted the bug as suggested. Additional JDK9 webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8173825.1/ Can you please sponsor it ? Thanks, Matthias

/ / /Best regards/ /Christoph/ / / / / /From: Baesken, Matthias/ /Sent: Donnerstag, 2. Februar 2017 15:44/ /To: //hotspot-dev at openjdk.java.net <http://mail.openjdk.java.net/mailman/listinfo/hotspot-dev>/// /Cc: Schmidt, Lutz <//lutz.schmidt at sap.com_ _<http://mail.openjdk.java.net/mailman/listinfo/hotspot-dev>//>; Langer, Christoph <christoph.langer at sap.com_ _<http://mail.openjdk.java.net/mailman/listinfo/hotspot-dev>//>; Simonis, Volker <volker.simonis at sap.com_ _<http://mail.openjdk.java.net/mailman/listinfo/hotspot-dev>//>/ /Subject: RFR [XXS] : Adjust the comment for flag UseAES in globals.hpp/ / / /Hello,/ / could I please have a review for the following small adjustment to the comment of UseAES in globals.hpp ./ /UseAES is available now on more than x86/x64, for example s390x and ppc64le so the comment in globals.hpp needs to be adjusted./ /I also need a sponsor for this./ / / /Bug :/ / / ///https://bugs.openjdk.java.net/browse/JDK-8173825/// / / /Webrev :/ / / ///http://cr.openjdk.java.net/~mbaesken/webrevs/8173825.0//// / /



More information about the hotspot-dev mailing list