RFR [XXS] : Adjust the comment for flag UseAES in globals.hpp (original) (raw)

Baesken, Matthias matthias.baesken at sap.com
Mon Feb 6 07:43:48 UTC 2017

Hi Vladimir, that's a good idea , thanks for adjusting it.

Best regards, Matthias

-----Original Message----- From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com] Sent: Freitag, 3. Februar 2017 18:47 To: Baesken, Matthias <matthias.baesken at sap.com>; hotspot- dev at openjdk.java.net Cc: Langer, Christoph <christoph.langer at sap.com> Subject: Re: RFR [XXS] : Adjust the comment for flag UseAES in globals.hpp

Hi Matthias, I looked on other flags and I want to remove line 667 too if you are okay with it: _665 product(bool, UseSHA, false, _ _666 "Control whether SHA instructions can be used " _ _667 "on SPARC, on ARM and on x86") _ Thanks, Vladimir On 2/3/17 3:52 AM, Baesken, Matthias wrote: >>>/Hi Matthias,/ > >>>/ / > >>>/looks good./ > >> > >>+1 > >> > >>>/ / > >>>/I'm wondering whether this textual change could still make it into > JDK9...?/ > >> > >>Make it P3 and change "Affects" and "Fix" version to 9. > >> > >> Thanks, > >> Vladimir > > > > Hi Vladimir, I adjusted the bug as suggested. > > > > Additional JDK9 webrev : > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8173825.1/ > > > > Can you please sponsor it ? > > > > Thanks, Matthias > > > > > >>>/ / > >>>/Best regards/ > >>>/Christoph/ > >>>/ / > >>>/ / > >>>/From: Baesken, Matthias/ > >>>/Sent: Donnerstag, 2. Februar 2017 15:44/ > >>>/To: //hotspot-dev at openjdk.java.net > <http://mail.openjdk.java.net/mailman/listinfo/hotspot-dev>/// > >>>/Cc: Schmidt, Lutz <//lutz.schmidt at sap.com_ _> <http://mail.openjdk.java.net/mailman/listinfo/hotspot-dev>//>; Langer, Christoph <christoph.langer at sap.com_ _> <http://mail.openjdk.java.net/mailman/listinfo/hotspot-dev>//>; Simonis, Volker <volker.simonis at sap.com_ _> <http://mail.openjdk.java.net/mailman/listinfo/hotspot-dev>//>/ > >>>/Subject: RFR [XXS] : Adjust the comment for flag UseAES in globals.hpp/ > >>>/ / > >>>/Hello,/ > >>>/ could I please have a review for the following small adjustment > to the comment of UseAES in globals.hpp ./ > >>>/UseAES is available now on more than x86/x64, for example s390x and > ppc64le so the comment in globals.hpp needs to be adjusted./ > >>>/I also need a sponsor for this./ > >>>/ / > >>>/Bug :/ > >>>/ / > >>>///https://bugs.openjdk.java.net/browse/JDK-8173825/// > >>>/ / > >>>/Webrev :/ > >>>/ / > >>>///http://cr.openjdk.java.net/~mbaesken/webrevs/8173825.0//// > >>>/ / > > >

More information about the hotspot-dev mailing list