[10] RFR(XS): 8180587: Assert in layout_helper_log2_element_size(jint) compares bits instead of bytes (original) (raw)
Tobias Hartmann tobias.hartmann at oracle.com
Thu May 18 07:47:57 UTC 2017
- Previous message: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems
- Next message: [10] RFR(XS): 8180587: Assert in layout_helper_log2_element_size(jint) compares bits instead of bytes
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
please review the following patch: https://bugs.openjdk.java.net/browse/JDK-8180587 http://cr.openjdk.java.net/~thartmann/8180587/webrev.00/
While working on value types, I wondered that the "l2esz <= LogBitsPerLong" assert in layout_helper_log2_element_size() did not fire although the array element size of a value type is greater than the size of a long. The problem is that the assert compares the log2 element size which is in bytes (see initialization in Klass::array_layout_helper()) to LogBitsPerLong which obviously is in bits.
Thanks, Tobias
- Previous message: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems
- Next message: [10] RFR(XS): 8180587: Assert in layout_helper_log2_element_size(jint) compares bits instead of bytes
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]