[10] RFR(XS): 8180587: Assert in layout_helper_log2_element_size(jint) compares bits instead of bytes (original) (raw)
Zoltán Majó zoltan.majo at oracle.com
Thu May 18 14:50:49 UTC 2017
- Previous message: [10] RFR(XS): 8180587: Assert in layout_helper_log2_element_size(jint) compares bits instead of bytes
- Next message: [10] RFR(XS): 8180587: Assert in layout_helper_log2_element_size(jint) compares bits instead of bytes
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Tobias,
the proposed change looks good to me.
Thank you!
Best regards,
Zoltan
On 05/18/2017 09:47 AM, Tobias Hartmann wrote:
Hi,
please review the following patch: https://bugs.openjdk.java.net/browse/JDK-8180587 http://cr.openjdk.java.net/~thartmann/8180587/webrev.00/ While working on value types, I wondered that the "l2esz <= LogBitsPerLong" assert in layouthelperlog2elementsize() did not fire although the array element size of a value type is greater than the size of a long. The problem is that the assert compares the log2 element size which is in bytes (see initialization in Klass::arraylayouthelper()) to LogBitsPerLong which obviously is in bits. Thanks, Tobias
- Previous message: [10] RFR(XS): 8180587: Assert in layout_helper_log2_element_size(jint) compares bits instead of bytes
- Next message: [10] RFR(XS): 8180587: Assert in layout_helper_log2_element_size(jint) compares bits instead of bytes
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]