RFR: 8202082: Remove explicit CMS checks in CardTableBarrierSetAssembler (original) (raw)

Kim Barrett kim.barrett at oracle.com
Thu Apr 26 04:36:44 UTC 2018

On Apr 25, 2018, at 9:53 AM, Erik Österlund <erik.osterlund at oracle.com> wrote:

Hi Kim, Okay, it looks like we kind of agree that this is a step in the right direction for now. Thank you for the review. Here is my final webrev with "disp" not refetched (and renamed to cardtableaddr): http://cr.openjdk.java.net/~eosterlund/8202082/webrev.01/ Incremental: http://cr.openjdk.java.net/~eosterlund/8202082/webrev.0001/

Only partially addressed my comment: src/hotspot/cpu/x86/gc/shared/cardTableBarrierSetAssembler_x86.cpp 105 intptr_t card_table_addr = (intptr_t)ctbs->card_table()->byte_map_base();

s/ctbs->card_table()/ct/

But wait, that version shouldn’t even compile? 107 card_addr = Address(noreg, obj, Address::times_1, disp); still refers to “disp”.

card_table_add is better than disp.

More information about the hotspot-dev mailing list