RFR: 8202082: Remove explicit CMS checks in CardTableBarrierSetAssembler (original) (raw)

Erik Österlund erik.osterlund at oracle.com
Thu Apr 26 06:52:48 UTC 2018

Hi Kim,

On 2018-04-26 06:36, Kim Barrett wrote:

On Apr 25, 2018, at 9:53 AM, Erik Österlund <erik.osterlund at oracle.com> wrote:

Hi Kim, Okay, it looks like we kind of agree that this is a step in the right direction for now. Thank you for the review. Here is my final webrev with "disp" not refetched (and renamed to cardtableaddr): http://cr.openjdk.java.net/~eosterlund/8202082/webrev.01/ Incremental: http://cr.openjdk.java.net/~eosterlund/8202082/webrev.0001/ Only partially addressed my comment: src/hotspot/cpu/x86/gc/shared/cardTableBarrierSetAssemblerx86.cpp 105 intptrt cardtableaddr = (intptrt)ctbs->cardtable()->bytemapbase(); s/ctbs->cardtable()/ct/ But wait, that version shouldn’t even compile? 107 cardaddr = Address(noreg, obj, Address::times1, disp); still refers to “disp”.

Fixed.

cardtableadd is better than disp.

Actually now that I think of it, I decided the name should be byte_map_base instead. That is indeed what the comments already refer to and what other platforms consistently call this variable. And it is not a real address.

Incremental: http://cr.openjdk.java.net/~eosterlund/8202082/webrev.01_02/

Full: http://cr.openjdk.java.net/~eosterlund/8202082/webrev.02/

Thanks, /Erik

More information about the hotspot-dev mailing list