RFR (XXS): 8031779: Assert in MetaspaceGC is always true (original) (raw)
Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Wed Jan 15 16:35:25 UTC 2014
- Previous message (by thread): RFR (XXS): 8031779: Assert in MetaspaceGC is always true
- Next message (by thread): RFR (XXS): 8031779: Assert in MetaspaceGC is always true
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good! /Jesper
Erik Helin skrev 15/1/14 5:09 PM:
Hi all,
another very small patch. As I've read through the code in MetaspaceGC::computenewsize I noticed an assert that always will be true: sizet maxshrinkbytes = capacityuntilGC - minimumdesiredcapacity; assert(maxshrinkbytes >= 0, errmsg("maxshrinkbytes " SIZEFORMAT, maxshrinkbytes)); The assert will be true since a sizet is always larger than or equal to zero. Webrev: http://cr.openjdk.java.net/~ehelin/8031779/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8031779 Thanks, Erik
- Previous message (by thread): RFR (XXS): 8031779: Assert in MetaspaceGC is always true
- Next message (by thread): RFR (XXS): 8031779: Assert in MetaspaceGC is always true
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]