RFR (XXS): 8031779: Assert in MetaspaceGC is always true (original) (raw)
Jon Masamitsu jon.masamitsu at oracle.com
Wed Jan 15 18:09:21 UTC 2014
- Previous message (by thread): RFR (XXS): 8031779: Assert in MetaspaceGC is always true
- Next message (by thread): RFR (XXS): 8031779: Assert in MetaspaceGC is always true
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Erik,
Change looks good. Thanks.
Jon
On 1/15/2014 8:09 AM, Erik Helin wrote:
Hi all,
another very small patch. As I've read through the code in MetaspaceGC::computenewsize I noticed an assert that always will be true: sizet maxshrinkbytes = capacityuntilGC - minimumdesiredcapacity; assert(maxshrinkbytes >= 0, errmsg("maxshrinkbytes " SIZEFORMAT, maxshrinkbytes)); The assert will be true since a sizet is always larger than or equal to zero. Webrev: http://cr.openjdk.java.net/~ehelin/8031779/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8031779 Thanks, Erik
- Previous message (by thread): RFR (XXS): 8031779: Assert in MetaspaceGC is always true
- Next message (by thread): RFR (XXS): 8031779: Assert in MetaspaceGC is always true
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]