Review Request (M) 8032379: Remove the is_scavenging flag to process_strong_roots (original) (raw)

Mikael Gerdin mikael.gerdin at oracle.com
Tue Jan 21 13:59:39 UTC 2014

On Tuesday 21 January 2014 14.54.15 Thomas Schatzl wrote:

Hi,

On Tue, 2014-01-21 at 14:13 +0100, Mikael Gerdin wrote: > Hi all, > > as a part of implementing JEP-156 (G1 class unloading) we are doing some > cleanups in order to refactor the strong root processing code. > > Currently there are two "dimensions" in which > SharedHeap::processstrongroots is configured. One is the ScanOption > enum, the other is the isscavenging booelan. The semantic meaning of > isscavenging can easily be folded into the ScanOption enum by: > > * Introducing a SOAllCodeCache/SOScavengeCodeCache distinction (in a way > similar to SOAllClasses/SOSystemClasses) > * Noting that passing a CLD closure to Threads::oopsdo is only needed > when we want to determine the precise liveness of classes, this is > already signaled by SOSystemClasses. > > Bug link: https://bugs.openjdk.java.net/browse/JDK-8032379 > Webrev: http://cr.openjdk.java.net/~mgerdin/8032379/webrev.0 Looks good to me.

Thanks for the review Thomas. /m

Thomas

More information about the hotspot-gc-dev mailing list